-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding: Garden type selection screen #507
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/1hive/honey-pot/GT3gjboApESegJRxgNdsEELdSGsH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! The logic was straight forward with the backbone in place 💪
margin-bottom: ${6 * GU}px; | ||
`} | ||
> | ||
<Card |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder what you think of also add the handleNext
handler to the onSelect
prop of each Card
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes i thought about it but wasn't sure, let's do it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the merge conflicts and we can merge it as well. Let's add a couple of new issues to address the TODOs
closes 1Hive/gardens#153
TODO:
Preview
![Screen Shot 2021-06-17 at 15 50 08](https://user-images.githubusercontent.com/22663232/122456240-b5a3ac00-cf83-11eb-85ac-9c9838fe7e8d.png)